Fix CI failure due to integrations leaving dirty known_devices.yaml #74329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecode
added
the
ci-full-run
probot-home-assistant
bot
added
bugfix
core
has-tests
integration: device_tracker
integration: demo
small-pr
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( |
balloob
reviewed
Jul 2, 2022
| @@ -165,6 +166,7 @@ async def test_setup_without_yaml_file(hass, enable_custom_integrations): | |||
| """Test with no YAML file.""" | |||
| with assert_setup_component(1, device_tracker.DOMAIN): | |||
| assert await async_setup_component(hass, device_tracker.DOMAIN, TEST_PLATFORM) | |||
| await hass.async_block_till_done() | |||
balloob
approved these changes
Jul 2, 2022
This was referenced Jul 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix broken CI due to multiple integrations and tests accessing/creating
known_devices.yamlfile and eventually leaving it behind when test ends.After long debugging the main issue was missing
await hass.async_block_till_done()in one of the device tracker tests. To reduce chances for failures two additional places which creates this file also cleaned-up.Thanks @epenet with #74255 which helped pinning this issue.
History of debugging this issue can be found on #74278
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: